1.x: new fromAsync to bridge the callback world with the reactive#4179
1.x: new fromAsync to bridge the callback world with the reactive#4179akarnokd merged 3 commits intoReactiveX:1.xfrom
Conversation
|
These errors, i.e., Travis running out of memory and killing tests, gets annoying... |
| } | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Really awesome tests. Easy to read and understand.
|
Updated. |
|
LGTM 👍 ! I'm surprised you couldn't reuse more of the existing infrastructure for the various backpressure modes here and instead need to have a full implementation of the whole queue/drain stuff. |
|
The codebase spans over several years now and there is no current "best toolset" for building operators. Besides, this inline saves allocation and overhead from applying other operators. |
|
/cc @stevegury @zsxwing as this is a new operator proposed to the public API |
|
|
||
| t.add(emitter); | ||
| t.setProducer(emitter); | ||
| asyncEmitter.call(emitter); |
There was a problem hiding this comment.
Shouldn't invoking this be deferred until request > 0?
There was a problem hiding this comment.
Why would we do that? The subscribe() itself triggers the execution of the body that sets up the push source.
There was a problem hiding this comment.
Yep, I guess it depends on what the implementation of the emitter is. I have a few use cases in my head I'm thinking through. Besides you could use AsyncOnSubscribe if you need that request coordination.
|
@JakeWharton how eager are you about this. I'd really love to merge all remaining PRs so 1.1.7 is as complete API-vise as possible. Otherwise, we may have to wait till 1.1.8 and 1.2 is also delayed. |
|
I would, of course, prefer that it made it. Releases are few and far between here so missing the boat might mean 3 months before it sees the light of day. That said, if no one from Netflix is available to review the API and it's the only thing blocking 1.1.7 then I'm fine with it missing the boat. |
|
I see low risk as this is a completely new operator. |
|
Thanks! On Sun, Jul 10, 2016, 2:36 AM David Karnok notifications@github.com wrote:
|
|
I wonder should this method be used instead of |
|
👍 |
4 participants
This PR adds a new source operator:
fromAsync()that let's bridge the callback-style world with the reactive world by providing a push surface and offers options to handle backpressure.